ResizeWithReflow doesn't clamp _virtualBottom if the cursor is above the viewport #17023
Labels
Area-Output
Related to output processing (inserting text into buffer, retrieving buffer text, etc.)
Issue-Bug
It either shouldn't be doing this or needs an investigation.
Priority-2
A description (P2)
Product-Terminal
The new Windows Terminal.
Milestone
Windows Terminal version
1a6ba43
Windows build number
No response
Other Software
No response
Steps to reproduce
TBA: Exact steps unclear, but it was found by @zadjii-msft in #16937 as part of reflow tests.
However, repro steps aren't quite necessary as the flaw can be clearly seen here:
terminal/src/host/screenInfo.cpp
Lines 1404 to 1407 in 1a6ba43
There's no
min()
. (Alternatively, you can just patchReflow()
to put the cursor at 0,0 after a reflow.)Terminal::UserResize
doesn't use itsnewCursorPos
either.Expected Behavior
No response
Actual Behavior
The viewport should always contain the cursor, even if the cursor is above the viewport.
The text was updated successfully, but these errors were encountered: