Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Refactor IRenderData and create IAccessibilityData #1992

Closed
carlos-zamora opened this issue Jul 16, 2019 · 0 comments · Fixed by #2296
Closed

Task: Refactor IRenderData and create IAccessibilityData #1992

carlos-zamora opened this issue Jul 16, 2019 · 0 comments · Fixed by #2296
Assignees
@carlos-zamora
Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal 1908.1

Comments

@carlos-zamora
Copy link
Member

A TODO for after PR #1915

IRenderData is supposed to be read-only, acting only as a method of querying the state of the terminal/console. The methods added in the PR may change the state.

We should try and separate out what we need for accessibility into a new interface: IAccessibilityData

In my mind, I'd like it if the relationship between IRenderData and the necessary accessibility functions (IAccessibilityData) would look something like this:

IBaseData
├─ IRenderData
└─ IAccessibilityData

  • IBaseData would provide a limited view for what IAccessibilityData needs from IRenderData
  • IRenderData would look the same
  • IAccessibilityData would get these functions that I added here (that would alleviate your concern)
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Jul 16, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 16, 2019
@carlos-zamora carlos-zamora self-assigned this Jul 16, 2019
@carlos-zamora carlos-zamora added this to the Terminal v1.0 milestone Jul 16, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 16, 2019
This was referenced Jul 16, 2019
Merged
Merged
@carlos-zamora carlos-zamora mentioned this issue Aug 6, 2019
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 6, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 19, 2019
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Accessibility Issues related to accessibility Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal 1908.1
Development

Successfully merging a pull request may close this issue.

Accessibility: Refactor IRenderData with IUiaData microsoft/terminal
1 participant
@carlos-zamora