Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Fix Accessibility BoundingRects for TextRanges #2103

Closed
carlos-zamora opened this issue Jul 25, 2019 · 1 comment · Fixed by #2423
Closed

Feature Request: Fix Accessibility BoundingRects for TextRanges #2103

carlos-zamora opened this issue Jul 25, 2019 · 1 comment · Fixed by #2423
Assignees
Labels
Area-Accessibility Issues related to accessibility Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@carlos-zamora
Copy link
Member

Summary of the new feature/enhancement

Thanks to #2083, we now have BoundingRects for text ranges. We can modify them and explore the text buffer properly.

Just one little problem...
image

The BoundingRects aren't actually on the text ranges properly. They update and function correctly, but they should look something like how they do in ConHost:
image

Proposed technical implementation details (optional)

There's a few places in UiaTextRange that use ScreenToClient() and ClientToScreen(); We can use them in ConHost because we have an HWND. Unfortunately, Windows Terminal doesn't have access to an HWND (and it seems like that'll be really hard to do).

XAML, on the other hand, should already know some information about bounding rects. That's how we got the one around the TermControl to appear and all of the other XAML elements.

We need to investigate if/how we can leverage XAML's knowledge of screen bounding rects and just pass them along to the UiaTextRange.

@carlos-zamora carlos-zamora added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Jul 25, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 25, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 25, 2019
@carlos-zamora carlos-zamora added this to the August Releases milestone Jul 31, 2019
@carlos-zamora carlos-zamora self-assigned this Jul 31, 2019
@ghost ghost added the In-PR This issue has a related PR label Aug 13, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 21, 2019
@ghost
Copy link

ghost commented Aug 27, 2019

🎉This issue was addressed in #2423, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant