Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Double Click Selection should span delimiter runs #2353

Closed
carlos-zamora opened this issue Aug 8, 2019 · 2 comments
Closed

Bug Report: Double Click Selection should span delimiter runs #2353

carlos-zamora opened this issue Aug 8, 2019 · 2 comments
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@carlos-zamora
Copy link
Member

Environment

Caused by #1197.
More apparent in #2184.

Steps to reproduce

  1. ensure double click delimiters includes " "
  2. double click on empty line

Expected behavior

Selection should encompass entire line.

Actual behavior

Selection encompasses one cell.

Additional Info

This one's on me. Idk why I thought that double clicking a delimiter should only select the delimiter itself. That's not useful.

Instead, the selection seems like it should expand to the first non-delimiter in either direction (exclusive range). For example,
O is non-delimiter
X is delimiter
Double clicking on any of the X would result in the following selection (denoted by [ and ])
OOOXXXXXXOOO
OOO[XXXXXX]OOO
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 8, 2019
@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 8, 2019
@carlos-zamora
Copy link
Member Author

Not sure if I'll be able to get to this one on time. I'm hoping that the PRs referenced above provide enough guidance to get started. Feel free to tackle this on (just be sure to mention that here).

@DHowett-MSFT
Copy link
Contributor

This looks like #2206 😉

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Aug 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlos-zamora @DHowett-MSFT