Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Accessibility Model to use wil #2474

Closed
carlos-zamora opened this issue Aug 19, 2019 · 2 comments · Fixed by #3051
Closed

Update Accessibility Model to use wil #2474

carlos-zamora opened this issue Aug 19, 2019 · 2 comments · Fixed by #3051
Assignees
@carlos-zamora
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal-1911

Comments

@carlos-zamora
Copy link
Member

Description of the new feature/enhancement

We currently manually keep track of our own RefCount for our accessibility providers. This can cause improper RefCounts and updating, as well as improper transferring of ownership.

We should be using the wil library to fix these issues. Starting by making references wil::com_ptrs. This probably won't be too bad for Windows Terminal. We'll have to update some ConHost code too.
@carlos-zamora carlos-zamora added Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Aug 19, 2019
@carlos-zamora carlos-zamora added this to the Terminal 1908.1 milestone Aug 19, 2019
@carlos-zamora carlos-zamora self-assigned this Aug 19, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 19, 2019
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 19, 2019
@carlos-zamora carlos-zamora mentioned this issue Aug 19, 2019
Merged
5 tasks
@DHowett-MSFT
Copy link
Contributor

And WRL!

@carlos-zamora carlos-zamora mentioned this issue Oct 4, 2019
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 4, 2019
@DHowett-MSFT
Copy link
Contributor

Moving this out to 1911. Splitting it into a fix for #3209.

@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal-1911
Development

Successfully merging a pull request may close this issue.

Upgrade UiaProviders to WRL::ComPtr microsoft/terminal
3 participants
@carlos-zamora @DHowett-MSFT @cinnamon-msft