Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bold characters are always brightWhite regardless of foreground color #3022

Closed
jdbruner opened this issue Oct 1, 2019 · 3 comments
Closed
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@jdbruner
Copy link

jdbruner commented Oct 1, 2019

Environment

Windows build number: 10.0.18995.0
Windows Terminal version (if applicable): 0.5.2661.0

Any other software?

Steps to reproduce

  1. Open a wsl tab using a light color scheme (e.g., Solarized Light)
  2. echo -e "\033[1mhello\033[0m"

Expected behavior

"hello" is printed in bold (or at least a darker version of the foreground color)

Actual behavior

"hello" is printed in brightWhite and is hard to see. (In some color schemes brightWhite is identical to the background color and is completely invisible)

It looks like the interpretation of the ANSI "bold" sequence is simply to render the following text in brightWhite. This "works" if the background is dark and the foreground is light, but it is pretty useless when using a light background and dark text. This impacts all programs that use the ANSI escape sequences (e.g., the "less" pager).

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 1, 2019
@DHowett-MSFT
Copy link
Contributor

/dup #2661

@ghost
Copy link

ghost commented Oct 1, 2019

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Oct 1, 2019
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 1, 2019
@DHowett-MSFT
Copy link
Contributor

Plus #293

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants