Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't help ( -h or --help) print to the console? #4887

Closed
MonkeyNinja opened this issue Mar 11, 2020 · 1 comment
Closed

Shouldn't help ( -h or --help) print to the console? #4887

MonkeyNinja opened this issue Mar 11, 2020 · 1 comment
Labels
Area-Commandline wt.exe's commandline arguments Issue-Question For questions or discussion Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered

Comments

@MonkeyNinja
Copy link

Not open a dialog...seems strange

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 11, 2020
@zadjii-msft
Copy link
Member

Oh it absolutely should, but shockingly, that's impossibly -.-

For reference, I'll refer you to this section in the spec for commandline arguments.

the TL;DR is that there are two types of executables on Windows: Windowed apps, and Console apps.

  1. A console app always needs a console, so if you were to launch wt from any context without a console (explorer, start menu, run dialog), then a console window will always be created for it.
  2. A Windows app can request a console is made for it, and can request to attache to it's parent console, but shells like cmd and powershell will have already continued running, because they don't wait for Windowed apps to complete before they return to the prompts.

Option 1 is bad, because we don't want another vintage console window appearing every time the Terminal is launched.

Option 2 is bad, because we can't print to the console before powershell or cmd has started printing again. Our output would get all mixed up with theirs.

So we opted for Option 3, which is to display a message box. This is at least an established pattern on Windows. In the meantime, we'll also be pushing on our side to try and make this better, because obviously this situation is not great.

@zadjii-msft zadjii-msft added Area-Commandline wt.exe's commandline arguments Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered labels Mar 11, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments Issue-Question For questions or discussion Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

2 participants