Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App loses focus after displaying modal dialog #5348

Closed
LarryBrasfield opened this issue Apr 14, 2020 · 2 comments
Closed

App loses focus after displaying modal dialog #5348

LarryBrasfield opened this issue Apr 14, 2020 · 2 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@LarryBrasfield
Copy link

LarryBrasfield commented Apr 14, 2020

Environment

Windows 10 [Version 10.0.18363.720]
Running TCC (a shell from J.P. Software) v.26.01.35
Windows Terminal Version: 0.10.781.0

Steps to reproduce

Cause the app to put up a modal dialog. For example, when running TCC's list command, by typing 'F' to initiate a search. Dismiss the pop-up.

Expected behavior

I expect focus to be returned to the application window that had it before the modal dialog appeared. In this case, that would be the TCC console. I expect to be able to keep typing and have keystrokes reach the app.

Actual behavior

Focus is given to the WT tab for the TCC instance instead. Typing does nothing. It is necessary to use alt-tab or a left-click in the application pane to return focus there before keystrokes again reach the app.

Possible duplicates

I saw several other bugs relating to lost and misplaced focus, but they were marked as fixed in this WT build. So this is either a new bug or reason to revert one of those others to "needs fixing".

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 14, 2020
@zadjii-msft
Copy link
Member

Okay this is not the most discoverable issue on our backlog, even I had to try a few times to find it and I knew it existed 😆

Shockingly, this is #2988. Conpty has some troubles when applications try to open a window on top of the "console"'s HWND, because conpty doesn't really have an HWND. So if the client app is trying to use GetConsoleWindow to get the Terminal's HWND, they're going to have a bad time.

/dup #2988

@ghost
Copy link

ghost commented Apr 14, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Apr 14, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 14, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants