Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Solarized Dark background matches brightBlack causing hidden argument text #6208

Closed
DepthDeluxe opened this issue May 26, 2020 · 4 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@DepthDeluxe
Copy link

Environment

Windows build number: Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0
Windows Terminal version (if applicable): 1.0.1401.0

I am running Powershell 7.0 in the terminal but I verified that this behavior also exists in older versions of Powershell.

Steps to reproduce

  1. Delete existing settings.json to fill in with default settings.
  2. Set the Powershell config to use the "Solarized Dark" theme.
  3. Open a new instance of Powershell in terminal and type testing123 -XYZ, the -XYZ portion will not be shown.

Expected behavior

I would expect to see "-XYZ" to still be visible. Perhaps it would be better to have command line arguments highlighted in white.

image

Actual behavior

The -XYZ text will not be shown as it is the same color as the background. I have verified this by overriding the "brightBlack" solarized theme color to any other color and it shows up.

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 26, 2020
@j4james
Copy link
Collaborator

j4james commented May 26, 2020

Yeah, unfortunately the Solarized color schemes are just not very good, and I think at this point everyone is regretting including them by default. See #4047, #2622, #4794, #4818, #5896, and #6061.

@skyline75489
Copy link
Collaborator

I used to love Solarized Dark and spent my time with it. Now it’s just kinda boring and also problematic.

Hey this would make a good rap song, if Eminem ever wanna rap about terminal color scheme.

@zadjii-msft
Copy link
Member

Yea I'm gonna close this as a dupe of the above threads. I agree with everyone - I liked Solarized at one point in the past, and I feel like I see it everywhere, but yea it's been nothing but trouble.

/dup #4047, #2622, #4794, #4818, #5896, and #6061

@ghost
Copy link

ghost commented May 27, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed May 27, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 27, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants