Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an action to gracefully upgrade a connection to a debug tap connection #7397

Open
zadjii-msft opened this issue Aug 25, 2020 · 4 comments
Open

Add an action to gracefully upgrade a connection to a debug tap connection #7397

zadjii-msft opened this issue Aug 25, 2020 · 4 comments
Assignees
@DHowett
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@zadjii-msft
Copy link
Member

/cc @DHowett

The debug tap is great. Really helpful for figuring out what we're getting from conpty. However, sometimes it's hard to get the terminal into a bugged state (see #6901, #6987), and if you didn't already have the debug tap open, then you can't use it.

I think it would be awesome if we could add an action to take the current connection, wrap it up in a debug tap, and open up a new pane to see the debug output.
@zadjii-msft zadjii-msft added Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 25, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 25, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 25, 2020
@DHowett
Copy link
Member

DHowett commented Aug 25, 2020

Holy crap, I love it!

@DHowett
Copy link
Member

DHowett commented Aug 25, 2020

We need a way to replace a TermControl's existing connection seamlessly with another one. That's intimidating, but I think doable.

@DHowett DHowett self-assigned this Aug 25, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 25, 2020
@DHowett
Copy link
Member

DHowett commented Aug 28, 2020

Good news!

debug_tap_inline

Open for ~bad~ fun news!

multitap

@zadjii-msft
Copy link
Member Author

image

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@DHowett @zadjii-msft