Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining menu item actions for right click on terminal tab (paste, splitPane, etc) #8703

Closed
nlaredo opened this issue Jan 4, 2021 · 4 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@nlaredo
Copy link

nlaredo commented Jan 4, 2021

Description of the new feature/enhancement

Allow defining menu item actions for right click on terminal tab (paste, splitPane, etc)

Proposed technical implementation details (optional)

Allow user to add actions to the menu that currently pops up when a tab is right clicked (currently Color, Rename Tab, Close) and show any key bound to the action as well, for example:

"Paste          ctrl+v"
"Find           ctrl+shift+f"
"splitPane      alt+shift+d"

This will allow the user to bind actions to menu items (automatically created for any command in the actions section of the config) to reclaim key sequences like ctrl+v for other tasks and use the right click menu to accomplish the same task while the configured command is bound to some undesirable key sequence like shift+insert. It will also provide an easy quick reference to the configured key bindings for the user.

@nlaredo nlaredo added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 4, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 4, 2021
@zadjii-msft
Copy link
Member

You know, there's gotta be a dupe of this somewhere on the repo. I've already mentioned doing this in a spec, so it's definitely a good idea. I think I mentioned it in #7175 and #5888. If I can't find the dupe, we can just use this thread to track it.

@Don-Vito
Copy link
Contributor

Don-Vito commented Jan 5, 2021

@zadjii-msft - we also had this discussion: #8318 (comment).

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Jan 7, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 7, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jan 7, 2021
@DHowett
Copy link
Member

DHowett commented Jan 28, 2021

Found it! /dup #1912! It was the original request for a context menu, and I think it is the appropriate place to track a customizable one since we absolutely do have a plain one today.

@ghost
Copy link

ghost commented Jan 28, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 28, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 28, 2021
@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 28, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants