Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nlohmann-json] update to 3.11.0 #26103

Closed
hamzaahmedzia1 opened this issue Aug 1, 2022 · 7 comments · Fixed by #26124
Closed

[nlohmann-json] update to 3.11.0 #26103

hamzaahmedzia1 opened this issue Aug 1, 2022 · 7 comments · Fixed by #26124
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@hamzaahmedzia1
Copy link

Library name: nlohmann-json

New version number: 3.11.0

Other information that may be useful (release notes, etc...)
https://github.com/nlohmann/json/releases/tag/v3.11.0

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 2, 2022
@SamVanheer
Copy link

Version 3.11.0 should be skipped since it has a bug. Version 3.11.1 should be used: https://github.com/nlohmann/json/releases/tag/v3.11.1

@JonLiu1993 JonLiu1993 linked a pull request Aug 3, 2022 that will close this issue
@falbrechtskirchinger
Copy link
Contributor

Version 3.11.2 will be released soon-ish. Both 3.11.0 and 3.11.1 have bugs and should be skipped. See #26124.

@ylz-at
Copy link

ylz-at commented Aug 5, 2022

Quick, quick, quick... 🤪

std::filesystem::path support is missing due to a bug(nlohmann/json#3240) in 3.10.5.

        #if defined(_MSC_VER) && _MSC_VER < 1940
            #undef JSON_HAS_FILESYSTEM
            #undef JSON_HAS_EXPERIMENTAL_FILESYSTEM
        #endif

@falbrechtskirchinger
Copy link
Contributor

Working on it. ;-)
Targeting Sunday at the earliest.

Also, the pdal port needs an update first, if someone wants to help. It should check for the existence of single_include/nlohmann/json_fwd.hpp in nlohmann-json (will be introduced in v3.11.2) and replace pdal/JsonFwd.hpp (make sure to patch the file the same way json.hpp is patched in the portfile).

@SamVanheer
Copy link

3.11.2 is out: https://github.com/nlohmann/json/releases/tag/v3.11.2

Doesn't look like there are any show-stopper issues.

@falbrechtskirchinger
Copy link
Contributor

3.11.2 is out: nlohmann/json@v3.11.2 (release)

Doesn't look like there are any show-stopper issues.

See #26124.

@SamVanheer
Copy link

Ah, thanks. I didn't realize the pull request had been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants