Icon fonts not hidden to screen readers

[anevins12]

Describe the bug
The demonstration code samples do not hide icons from screen readers.

To Reproduce
Steps to reproduce the behavior:

1. Go to the demo.
2. Inspect the element containing the pseudo attribute.
3. Identify that the font icon is exposed in the accessibility tree, for instance, in Chrome as "StaticText "".

Expected behavior
The icon should be hidden from the accessibility tree so that it is not announced by screen readers. This can be achieved by adding aria-hidden="true" to the containing element.

[miguelsolorio]

The demo is a sample of how to use the icons in an HTML page, it's not intended to be used in production.

[anevins12]

I don't understand. The document is live and in production right now, as it's a Github web page. A Github web page is not exempt from screen reader support or accessibility support.

[miguelsolorio]

That's a fair point, this page isn't used in any of our vscode products and was meant to only be used as a demo. I'll work on adding the appropriate aria labels.