Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt VSCode 1.20's new CodeAction type #399

Closed
mjbvz opened this issue Jan 26, 2018 · 1 comment
Closed

Adopt VSCode 1.20's new CodeAction type #399

mjbvz opened this issue Jan 26, 2018 · 1 comment
Labels
feature-request Request for new features or functionality

Comments

@mjbvz
Copy link

mjbvz commented Jan 26, 2018

VS Code 1.20 adds a new CodeAction type that attaches additional metadata to code actions. This additional information is already being used in a few places:

  • CodeAction.kind describes the kind of a code action (extract refactoring, quickfix, ...) Kinds are used for VS Code's new refactor command, and they are used to setup keybindings for specific code actions

  • CodeAction.diagnostics tells which errors a quickfix addresses. This is used to order quickfixes by severity

I suggest that you migrate this extension to use the new CodeAction type in order to enable support for these new features.

Depends on microsoft/language-server-protocol#389.
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Oct 17, 2019
@dbaeumer dbaeumer added this to the On Deck milestone Oct 17, 2019
@dbaeumer
Copy link
Member

Dups #497

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 1, 2019
@dbaeumer dbaeumer removed this from the On Deck milestone Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbaeumer @mjbvz