-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need Insider Testers for new ESLint extension version #815
Comments
Thank you! Working like a charm, so far. |
@rchl you should use vscode insiders, which is at v1.41.0, to test the extension. |
@gso-visiona thanks for providing this. I should definitely mention this. |
Is there a reason for that requirement though? Older versions are missing some required API? |
It is not an API problem it is an internal VS Code implementation problem. To get things working I needed fixes in VS Code itself for settings and code actions on save. These are only in insider but will be in the next stable release. |
@zanza00 thanks for reporting this back. |
So excited about this! I have a little discrepancy… I have a project using eslint-plugin-prettier and, while running |
The solution I imagine for this is that user can provide different config file for format and fix which will allow them to customize this. |
Sorry, I'm not following. Shouldn't the CLI and plugin behave the same by default? Currently, they're doing different things. |
@matthewwithanm I think I misread what you posted. I was talking about different config and ignore files. Your case should actually work in the new version. Did it fail for you? If so can you please provide me with a GitHub repository I can clone that demos this. |
Can I suggest that Since |
@sebinsua this is now supported. Did it not work for you? From the above comment:
|
Apologies, I hastily went into this issue and didn't understand what |
@sebinsua Great to hear that it works for you! |
I installed this to resolve missing error detection in my first, recently created lerna repo and it works out of the box now. Thanks for this improvement! |
The formatter option is working great (ESLint 2.0.1, VSC Insiders 1.41.0). I really like having that option in addition to fix on save (which is also working for me with the new system). |
(This was the only extension I had installed when reproing.) |
@matthewwithanm thanks a lot. This is indeed something I broke to easy the setup of eslint 6.x repositories. However ignore files are not consider up the hierarchy (neither for eslint nor for prettier) and in these cases I shouldn't set the cwd to dir. |
It would be nice if the extension did not auto-change the |
With the 2.0.2 version of this extension with VSCode 1.41.0, having the It seems the extension searches my tsconfig file at the same level of each .ts file instead of the root of the workspace. which was not the case with version 1.9.1. |
@snario I noticed the same and working on a new version that fixes this. The old settings will be deprecated and you can have both in parallel for a while. |
@EtienneBourque I am working on a fix for this. To ensure this will fix your problem can you provide me with a GitHub repository I can clone that demos your problem. |
I published a new version of the insider here: https://github.com/microsoft/vscode-eslint/releases/tag/2.0.3-next.1 It addresses @snario concerns about settings migration. It keeps the old settings for now, however to get the code action on save working it add some new once. However this will not affect users using the old version of the extension. I also addressed problems around choosing the right working directory. However this is very tricky in ESLint because the
I would appreciate if people could give the new version another try. |
Vscode released version 1.41, which means this can now be installed without the need for Insiders release. |
@gso-visiona thanks for pointing this out. |
While you published 2.0.3, I was creating a little demo workspace to show the problem I was having with 2.0.2. I just tested with 2.0.3 and it's fixed. Thanks! Here's my demo anyway: https://github.com/EtienneBourque/eslint-tsconfig With 2.0.2, I would get errors with tsconfig.json not being found when opening any file not in the root directory. |
I just wanted to experiment with Could that be related to the changes that were made here or is it something different? So e.g.:
After saving:
|
@s-h-a-d-o-w which version of the extension are you using. The |
I officially publish 2.0.4 of the extension. Please provide any kind of feedback using a new issue. Thanks you all for your testing! |
Hi all,
I have spent some time to add highly voted features to the ESLint extension. I am asking people in the community to help me test the features since they required quite some rewrite and a bunch of new code. New features are:
eslint.format.enable
.eslint.probe
and it is an array of language ids for which ESLint should try to validate the content. If validating fails ESLint will stay silent. Probe languages are:"javascript", "javascriptreact", "typescript", "typescriptreact", "html", "vue"
.autofix
part is gone from the validate settings. The extension now always computes fixes. So it is now simply a array of language id.eslint.workingDirectories
setting. It still exist, however if provided it will automatically change the process cwd. This can be suppressed using the'!cwd'
property.I will monitor the inbox the next couple of days to react to bugs people encounter with the new version.
Warning
Using the new extension converts the settings to the new format. This is necessary to support code actions for auto fix. So please backup your settings file before installing and using the extension.
Prerequisite
The insider extension needs that latest VS Code stable or Insider build versioned at 1.41.x. or higher.
The extension can be found here: https://github.com/microsoft/vscode-eslint/releases/tag/2.0.3-next.1
The text was updated successfully, but these errors were encountered: