Diagnostics pulling doesn't work for notebook cells

[rchiodo]

I'm attempting to switch Pylance to use a pull method for diagnostics but I'm not getting textDocument/diagnostic messages for notebook cells.

I believe that's because notebook changes aren't tracked here:

vscode-languageserver-node/client/src/common/diagnostic.ts

Line 1024 in 8e62556

if (diagnosticPullOptions.onChange === true) {

And notebook opens aren't tracked here:

vscode-languageserver-node/client/src/common/diagnostic.ts

Line 962 in 8e62556

const openFeature = client.getFeature(DidOpenTextDocumentNotification.method);

[dbaeumer]

Diagnostic pull is not available for notebook cells. It would require a special implementation in the notebook.ts file. It should work for the underlying document of the cell but that is not what you are asking for.

[rchiodo]

It should work for the underlying document of the cell but that is not what you are asking for.

Sorry, I'm not sure what you mean. Are you saying there's an alternative method to get the requests? Or are you saying something still needs to be implemented?

[rchiodo]

I'm working on the changes to notebook.ts to add support for this. Doesn't seem too hard. Diagnostics.ts just needs to know the same events that are sent for regular documents.

[rchiodo]

Please take a look at my PR. Thanks.