Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPI: FastAPI tutorial [part 1] #22299

Closed
2 tasks done
luabud opened this issue Oct 24, 2023 · 2 comments
Closed
2 tasks done

TPI: FastAPI tutorial [part 1] #22299

luabud opened this issue Oct 24, 2023 · 2 comments
Labels
testplan-item Test plan item/assignments for upcoming release
Milestone

Comments

@luabud
Copy link
Member

luabud commented Oct 24, 2023

Refs: #21586

Complexity: 3

Create Issue


We are adding a FastAPI tutorial to our Python docs page (PR). Because it's a fairly large doc to go through, I've broken it down into smaller pieces for the TPIs. You should be able to run through the section defined in this issue without having to read any previous content from the doc.

Steps:

  1. Run through the "locally in VS Code" section in the tutorial-fastapi.md file in this PR: Add FastAPI tutorial to Python docs  vscode-docs#6760

Things we're looking for in this TPI:

  • Ensure the guidance makes sense and is accurate
  • Ensure you get to a successful state at each step
  • Any feedback on wording/structure of the tutorial

You can feel free to open issues with problems you find, or comment in the PR directly.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 24, 2023
@luabud luabud added testplan-item Test plan item/assignments for upcoming release and removed triage-needed Needs assignment to the proper sub-team labels Oct 24, 2023
@lszomoru
Copy link
Member

lszomoru commented Oct 24, 2023

It's probably easier to consume the markdown file here, than in the PR view.

@lszomoru
Copy link
Member

Went through the "locally in VS Code" section on macOS. Everything worked as expected. I have added some comments to the PR as that seemed the most convenient way to provide feedback directly in the documentation.

@lszomoru lszomoru removed their assignment Oct 24, 2023
@karthiknadig karthiknadig added this to the October 2023 milestone Oct 24, 2023
@minsa110 minsa110 removed their assignment Oct 24, 2023
@luabud luabud closed this as completed Oct 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testplan-item Test plan item/assignments for upcoming release
Projects
None yet
Development

No branches or pull requests

4 participants