Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI Tutorial: Code sample not matching #22307

Closed
aeschli opened this issue Oct 24, 2023 · 2 comments
Closed

FastAPI Tutorial: Code sample not matching #22307

aeschli opened this issue Oct 24, 2023 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug documentation info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team verified Verification succeeded
Milestone

Comments

@aeschli
Copy link

aeschli commented Oct 24, 2023

Testing #22302

  • Step 6 of 'Replace the database' says:

replace if item_name in items_names:

I can't find that code, it should be:
if item_name in items_ids.keys():

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 24, 2023
@luabud luabud self-assigned this Oct 24, 2023
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug documentation labels Oct 24, 2023
@luabud
Copy link
Member

luabud commented Oct 25, 2023

Great catch, thanks! Fixed by microsoft/vscode-docs@5b8cdfc

@luabud luabud closed this as completed Oct 25, 2023
@luabud luabud added this to the October 2023 milestone Oct 25, 2023
@eleanorjboyd
Copy link
Member

@luabud how do I see this reflected in the md? I looked https://github.com/microsoft/vscode-docs/blob/6273480067954e1ca21de49abfbeae9798d6ff3c/docs/python/tutorial-fastapi.md and still see the old code

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Oct 26, 2023
@gregvanl gregvanl added the verified Verification succeeded label Oct 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug documentation info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants