Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create setting for Python execution to be on Native REPL or Terminal #23458

Closed
Tracked by #23332
anthonykim1 opened this issue May 21, 2024 · 2 comments
Closed
Tracked by #23332
Assignees
Labels
feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@anthonykim1
Copy link

anthonykim1 commented May 21, 2024

With the IW REPL Experiment, we should create setting to correctly bind shift+enter to send Python command to REPL in IW or Terminal. This also means we would only show the relevant context menu when user right clicks on their editor screen.

For example, if user has toggled on their settings to Send Python command to Terminal(Default and for control group of experiment), shift+enter would send Python command to Terminal and context menu will NOT show Run selection/line in Python REPL

If the user has toggled on their settings to Send Python command to REPL (on for treatment group of the experiment), shift+enter would send Python command to REPL with IW UI, and context menu via right clicking on editor screen will NOT show Run selection/line in Terminal

@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label May 21, 2024
@anthonykim1 anthonykim1 self-assigned this May 21, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 21, 2024
@anthonykim1 anthonykim1 added this to the May 2024 milestone May 21, 2024
@anthonykim1
Copy link
Author

Closed via: #23442

@benibenj benibenj added the verification-needed Verification of issue is requested label May 28, 2024
@anthonykim1
Copy link
Author

This will be tested via: #23484 hence marking as verified so they do not appear in endgame queries.

@anthonykim1 anthonykim1 added verified Verification succeeded and removed triage-needed Needs assignment to the proper sub-team verification-needed Verification of issue is requested labels May 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants