Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to loading times of Python Extension #2853

Closed
4 of 8 tasks
DonJayamanne opened this issue Oct 11, 2018 · 0 comments
Closed
4 of 8 tasks

Improvements to loading times of Python Extension #2853

DonJayamanne opened this issue Oct 11, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project needs proposal Need to make some design decisions

Comments

@DonJayamanne
Copy link

DonJayamanne commented Oct 11, 2018

Following are some changes that can be made to improve the load times of the python extension:

Changes required

Long Term Changes:

  • Create perf tests to measure and compare code load times of extension #3022 Create more perf tests to measure and compare load times of extension, in particular the following times:
    • codeLoadingTime
    • activateCallTime
    • activateResolvedTime
      We have tests today that do something similar, we need to ensure they are more granular. (compare against release and dev versions of extension - as done today).
  • Change interpreters list into an Observable list #3023 Observable list of interpreters (currently we need any, subsribe, filter, and similar capabitlies of interpreters, but in a non-blocking way, thats exactly that Observable lists provide - RxJs).
    • Short term solution could be to add new code for perf improvements
    • E.g. add a predicate to IInterpreterService.getInterpreters, add methods IInterpreterService.hasAny, IInterpreterService.onChange()

@Microsoft/pvsc-team /cc

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs proposal Need to make some design decisions labels Oct 11, 2018
@DonJayamanne DonJayamanne self-assigned this Oct 11, 2018
@DonJayamanne DonJayamanne changed the title Improvements to loading of Python Extension Improvements to loading times of Python Extension Oct 11, 2018
@microsoft microsoft locked and limited conversation to collaborators Oct 11, 2018
@DonJayamanne DonJayamanne added meta Issue that is tracking an overall project important Issue identified as high-priority unplanned and removed P0 labels Oct 11, 2018
@brettcannon brettcannon reopened this Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority meta Issue that is tracking an overall project needs proposal Need to make some design decisions
Projects
None yet
Development

No branches or pull requests

2 participants