Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation issue with newline in strings #4563

Closed
michaelmyc opened this issue Feb 27, 2019 · 6 comments
Closed

Indentation issue with newline in strings #4563

michaelmyc opened this issue Feb 27, 2019 · 6 comments
Labels
area-editor-* User-facing catch-all area-formatting bug Issue identified by VS Code Team member as probable bug

Comments

@michaelmyc
Copy link

Environment data

  • VS Code version: 1.31.1
  • Extension version (available under the Extensions sidebar): 2019.2.5416
  • OS and version: Manjaro
  • Python version (& distribution if applicable, e.g. Anaconda): Miniconda 3.7
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Relevant/affected Python packages and their versions: XXX

Expected behaviour

No indentation after print("\n").

Actual behaviour & Steps to reproduce:

peek 2019-02-27 00-07

Logs

Output for Python in the Output panel (ViewOutput, change the drop-down the upper-right of the Output panel to Python)

Starting Jedi Python language engine.
##########Linting Output - pylint##########

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 27, 2019
@Ronkiro
Copy link

Ronkiro commented Feb 27, 2019

Occurs with any strings that contains \.

i.e.: 'a\ a', '\', "\", "a\"

@michaelmyc
Copy link
Author

Hopefully, this gets solved quickly as escape characters are very common and incorrect indenting is very frustrating.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug area-formatting labels Feb 27, 2019
@ghost ghost removed triage-needed Needs assignment to the proper sub-team labels Feb 27, 2019
@DonJayamanne DonJayamanne added important Issue identified as high-priority needs PR labels Feb 27, 2019
@luabud luabud added important Issue identified as high-priority and removed important Issue identified as high-priority labels Mar 12, 2019
@luabud luabud removed the important Issue identified as high-priority label Mar 26, 2019
@AlanLivingston
Copy link

Why was P1 removed? This is an incredibly annoying bug.

@jkyeung
Copy link

jkyeung commented Apr 5, 2019

This is indeed amazingly annoying. It looks like it is related to "fixing" indentation for line-continuation backslashes (which, let's face it, are vastly less common than backslashes within strings).

This is a duplicate of #4241.

@jkyeung
Copy link

jkyeung commented Aug 21, 2019

This issue can be closed since #4241 was fixed and closed.

@Ronkiro
Copy link

Ronkiro commented Aug 22, 2019

I just tested, and yes, it seems fixed.

@DonJayamanne mind closing this one?

@luabud luabud closed this as completed Oct 8, 2019
@ghost ghost removed the needs PR label Oct 8, 2019
@gramster gramster added the area-editor-* User-facing catch-all label Oct 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all area-formatting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

7 participants