Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prompt asking users to enroll back in the insiders program #7473

Closed
karrtikr opened this issue Sep 18, 2019 · 2 comments
Closed

Add a prompt asking users to enroll back in the insiders program #7473

karrtikr opened this issue Sep 18, 2019 · 2 comments
Assignees
@ericsnowcurrently @karrtikr
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2019 - September ...

Comments

@karrtikr
Copy link

karrtikr commented Sep 18, 2019 •
edited by ericsnowcurrently
Loading

Several users were opted out of the insiders program due to bug #7444 . For the users whose python.insidersChannel is explicitly set to off (instead of using the default), show the following prompt:

Prompt message: It looks like you were previously in the Insiders Program of the Python extension. Would you like to opt into the program again?
[Yes, weekly updates] [Yes, daily updates] [No, thanks]
@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug needs PR labels Sep 18, 2019
@karrtikr karrtikr added this to the 2019 - September Sprint 2 milestone Sep 18, 2019
@karrtikr karrtikr added important Issue identified as high-priority and removed P0 labels Sep 18, 2019
@karrtikr karrtikr self-assigned this Sep 18, 2019
@karrtikr karrtikr mentioned this issue Sep 19, 2019
Merged
7 tasks
@DonJayamanne
Copy link

@karrtikr Please see issue #7535
I believe there's something wrong with the logic that has been implemented.

@ericsnowcurrently ericsnowcurrently self-assigned this Sep 23, 2019
@ericsnowcurrently
Copy link
Member

I got the prompt under insiders after explicitly using "off" for the setting.

@ghost ghost removed the needs PR label Sep 25, 2019
@greazer greazer mentioned this issue Sep 25, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericsnowcurrently ericsnowcurrently

@karrtikr karrtikr

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2019 - September Sprint 2
Development

No branches or pull requests
3 participants
@ericsnowcurrently @DonJayamanne @karrtikr