Redo drop does not work for single file

[aeschli]

Testing #111015

Ubuntu

• In the Ubuntu file explorer, select a file a drop in the VSCode explorer
• from the window menu, run Edit > Undo. Copy is undone ✔️
• from the window menu, run Edit > Redo. Nothing happens

Interestingly, dropping 2 files and undo - redo works

[isidorn]

For me I see something differently. In the last step the Redo works, however the file is brough back empty.

This is due to the fact that we pass true here as the _undoesCreateOperation

vscode/src/vs/workbench/contrib/bulkEdit/browser/bulkFileEdits.ts

Line 97 in f4187f2

return this._instaService.createInstance(DeleteOperation, this.newUri, this.options, { isUndoing: true }, true);

I have verified that passing false here actually fixes the issue.
Though I know @jrieken introduced this flag for a reason. Thus also assigning this issue to him

[jrieken]

@isidorn Using false should be OK for that case. Basically that is there to know if delete in undoing a create operation. Create should be understood as "create empty file", not as copy or as re-create after delete.

[isidorn]

@jrieken thanks. Pushed that fix then
@aeschli I understand I did not fix 100% the issue you were seeing, but a similar issue. However still closing this, and you can try with latest out of source and let me know if you still see something strange. I believe your original issue was also connected to the focus and is basically a dupe of #111640

[jrieken]

Thanks @isidorn. This is why all of this is so complicated: #107379. The gist is that undo of create should only restore contents when create was invoked with contents, not if the contents came later. Using your changes I have re-verified #107379 and things are happy

[isidorn]

Thanks for re-verifiying.

[aeschli]

Verified that setting the focus on the explorer solves the issue.