Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve interactive window input editor styling #128766

Closed
rebornix opened this issue Jul 15, 2021 · 2 comments
Closed

Improve interactive window input editor styling #128766

rebornix opened this issue Jul 15, 2021 · 2 comments
Assignees
@rebornix
Labels
feature-request Request for new features or functionality interactive-window verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2021

Comments

@rebornix
Copy link
Member

Originally discussed in #126415 (comment)
@rebornix rebornix added feature-request Request for new features or functionality interactive-window labels Jul 15, 2021
@rebornix rebornix added this to the July 2021 milestone Jul 15, 2021
@rebornix rebornix self-assigned this Jul 15, 2021
@egamma egamma mentioned this issue Jul 19, 2021
Closed
82 tasks
@rebornix
Copy link
Member Author

Based on the UX discussions we had offline, we now render the input editor like a code cell, which will honor the focus indicator setting of notebook.

Focus indicator: gutter

image

Focus indicator: border

image

@rebornix
Copy link
Member Author

Fixed via 84d6fbc.

@rzhao271 rzhao271 added the verification-needed Verification of issue is requested label Jul 27, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jul 27, 2021
@joyceerhl joyceerhl mentioned this issue Aug 12, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
feature-request Request for new features or functionality interactive-window verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2021
Development

No branches or pull requests
3 participants
@rebornix @connor4312 @rzhao271