Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Screen reader support: Sync prompt with xterm.js textarea #139403

Closed
Tyriar opened this issue Dec 17, 2021 · 2 comments
Closed

Shell integration: Screen reader support: Sync prompt with xterm.js textarea #139403

Tyriar opened this issue Dec 17, 2021 · 2 comments
Assignees
@Tyriar @meganrogge
Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021 •
edited
Loading

Parent issue #133084

Blocked on:

Notes:

  • Currently we clear the invisible text area in xterm.js when we're unsure what the prompt's state is, with real command tracking we will be able to synchronize the textarea with the prompt and cursor to get left/right/backspace/delete correctly announcing the textual changes to screen reader users
  • Considerations:
    • This might need to be a new API in xterm.js so it avoids clearing the textarea
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Dec 17, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 17, 2021
@Tyriar Tyriar mentioned this issue Dec 17, 2021
Closed
@meganrogge
Copy link
Contributor

Investigated this and it seems to be mostly working fine for screen readers. Word navigation does not work at the moment and we might want to consider announcing the output

@meganrogge meganrogge assigned Tyriar and unassigned Tyriar Jan 18, 2022
@Tyriar Tyriar modified the milestones: January 2022, Backlog Jan 27, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jan 27, 2022

Closing this out until we get some solid reports where we could improve

@Tyriar Tyriar closed this as completed Jan 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge