Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration: Explore using relative link cwd depending on what the cwd was for that output block #139408

Closed
Tyriar opened this issue Dec 17, 2021 · 0 comments · Fixed by #140676
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes plan-item VS Code - planned item for upcoming terminal-links terminal-shell-integration Shell integration, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2021

Parent issue #133084

Blocked on:

If we know what the cwd was for each prompt/output block, we can now be smarter about which cwd to resolve links relatively to. For example, print some relative link then cd into some other directory, the link should use the past working directory that was active when it was printed.

@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Dec 17, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 17, 2021
@Tyriar Tyriar removed their assignment Jan 14, 2022
@meganrogge meganrogge added the on-release-notes Issue/pull request mentioned in release notes label Jan 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders on-release-notes Issue/pull request mentioned in release notes plan-item VS Code - planned item for upcoming terminal-links terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Tyriar @meganrogge and others