Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell integration: Use command tracking as alternative child process tracking #139522

Closed
Tyriar opened this issue Dec 20, 2021 · 5 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code perf terminal-shell-integration Shell integration, command decorations, etc.

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 20, 2021

Use command tracking to save running a process for whether the shell is dirty, similar to cwd tracking this will lead to more responsive UI and less work happening on update. https://github.com/microsoft/vscode/blob/a1bf964306d30a9bbccb404b1b653e5a02fe3052/src/vs/platform/terminal/node/childProcessMonitor.ts

@Tyriar Tyriar added the plan-item VS Code - planned item for upcoming label Dec 20, 2021
@Tyriar Tyriar added this to the January 2022 milestone Dec 20, 2021
@meganrogge
Copy link
Contributor

Blocked by supporting subshells

@Tyriar
Copy link
Member Author

Tyriar commented Jan 25, 2022

Created the subshell issue #141343, instead of relying on sub-shell support, we could just say when the shell is not in the prompt, the terminal's busy. This is arguably better than the current child process support anyway as the terminal is doing something. Sub-shells are a problem as it would always be busy, but that's a problem that could be handled with #131343.

Need to way the pros/cons for both ways.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 26, 2022

Ideas:

  • Move child process tracking into a capability which uses onFirstListenerAdd and onLastListenerRemove to only turn that mechanism on when needed
  • If the command detection capability is available, prefer that and expose a new property/event for when the cursor is in the prompt.

This should make the dirty indicator much more responsive as well.

@Tyriar Tyriar modified the milestones: January 2022, February 2022 Jan 26, 2022
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration, command decorations, etc. and removed plan-item VS Code - planned item for upcoming labels Jan 26, 2022
@Tyriar Tyriar modified the milestones: February 2022, March 2022 Feb 24, 2022
@Tyriar Tyriar modified the milestones: March 2022, Backlog Mar 7, 2022
@Tyriar Tyriar added the perf label Jun 3, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jun 3, 2022

This is mainly a small performance improvement where we would be able to not poll for the process tree as much.

@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Dec 12, 2023
@VSCodeTriageBot
Copy link
Collaborator

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code perf terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Development

No branches or pull requests

4 participants