Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tasks.json to generate multiline problem messages #69183

Closed
AshleyYakeley opened this issue Feb 22, 2019 · 5 comments
Closed

Allow tasks.json to generate multiline problem messages #69183

AshleyYakeley opened this issue Feb 22, 2019 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues

Comments

@AshleyYakeley
Copy link

So 1.31 apparently introduces multiline messages in the problem panel. But there does not seem to be any documented way to actually generate these messages, such as in tasks.json, from arbitrary build tools.

The available documentation mentions "multiline problems", but the messages must still be each on a single line, whereas the messages I want to match are each multiline. Here's an example, from the output of the GHC compiler:

    /home/ashley/Projects/Haskell/Truth/truth-gtk/text/Main.hs:62:44: error:
        • Couldn't match expected type ‘(UISpec sel edit, Bool)
                                        -> (UISpec sel edit, Bool)’
                      with actual type ‘(UISpec sel1 tedit1, Bool)’
        • The function ‘(menuBarUISpec mbar, False)’
          is applied to one argument,
          but its type ‘(UISpec sel1 tedit1, Bool)’ has none
          In the expression: (menuBarUISpec mbar, False) (spec, True)
          In the first argument of ‘verticalUISpec’, namely
            ‘[(menuBarUISpec mbar, False) (spec, True)]’
        • Relevant bindings include
            spec :: UISpec sel edit (bound at text/Main.hs:59:50)
            simpleUI :: (UIWindow, ()) -> UISpec sel edit -> UISpec sel edit
              (bound at text/Main.hs:59:21)
       |
    62 |                         in verticalUISpec [(menuBarUISpec mbar,False)(spec,True)]
       |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    

Currently the best I can do is match the first line.

@vscodebot vscodebot bot added the tasks Task system issues label Feb 22, 2019
@alexr00
Copy link
Member

alexr00 commented Feb 22, 2019

Info about multiline problem matchers for tasks is here: https://code.visualstudio.com/Docs/editor/tasks#_defining-a-multiline-problem-matcher

@alexr00 alexr00 closed this as completed Feb 22, 2019
@alexr00 alexr00 added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Feb 22, 2019
@AshleyYakeley
Copy link
Author

This is not correct!! As I pointed out:

The available documentation mentions "multiline problems", but the messages must still be each on a single line, whereas the messages I want to match are each multiline.

@AshleyYakeley
Copy link
Author

@alexr00 just to clarify, the documentation you point to is for multiline problems with single-line messages. The feature introduced in 1.31 is multiline problems with multi-line messages.

@alexr00
Copy link
Member

alexr00 commented Feb 22, 2019

I see. Then this is a duplicate of #9635, which we are considering adding API for.

@alexr00 alexr00 added *duplicate Issue identified as a duplicate of another issue(s) and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Feb 22, 2019
@AshleyYakeley
Copy link
Author

OK, it looks like you're treating the change you made in 1.31 as a partial fix to #9635, leaving that issue open until it's complete.

Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants