Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing key UserExtend for Enum AccessPackageRequestType #661

Open
shemogumbe opened this issue Aug 12, 2024 · 0 comments
Open

Missing key UserExtend for Enum AccessPackageRequestType #661

shemogumbe opened this issue Aug 12, 2024 · 0 comments
Assignees
Labels
Area: OpenAPI An issue related to the OpenAPI library Area: Workload priority:p1 High priority but not blocking.

Comments

@shemogumbe
Copy link

Fixes microsoftgraph/msgraph-sdk-python#838

Raised in python, the missing key UserExtend for Enum AccessPackageRequestType affects all SDKs.

While generation is fine , it maps the enum definition in the OpenAPI file:

microsoft.graph.accessPackageRequestType:
      title: accessPackageRequestType
      enum:
        - notSpecified
        - userAdd
        - userUpdate
        - userRemove
        - adminAdd
        - adminUpdate
        - adminRemove
        - systemAdd
        - systemUpdate
        - systemRemove
        - onBehalfAdd
        - unknownFutureValue
      type: string

To the generated Python Enum Model as:

from enum import Enum

class AccessPackageRequestType(str, Enum):
    NotSpecified = "notSpecified",
    UserAdd = "userAdd",
    UserUpdate = "userUpdate",
    UserRemove = "userRemove",
    AdminAdd = "adminAdd",
    AdminUpdate = "adminUpdate",
    AdminRemove = "adminRemove",
    SystemAdd = "systemAdd",
    SystemUpdate = "systemUpdate",
    SystemRemove = "systemRemove",
    OnBehalfAdd = "onBehalfAdd",
    UnknownFutureValue = "unknownFutureValue",

More Details
The openapi.yaml shows that UserExtend exists in the description, but it does not exist in the definition as shown above.
image

Workload owner or metadata update required
Checking the description, seems the key has not been added by the workload owner as well:
image (1)

Solution
Adding this will automatically solve this for all SDKs.

@shemogumbe shemogumbe added Area: OpenAPI An issue related to the OpenAPI library metadata-issue An issue with the metadata priority:p1 High priority but not blocking. labels Aug 12, 2024
@irvinesunday irvinesunday added Area: Workload and removed metadata-issue An issue with the metadata labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OpenAPI An issue related to the OpenAPI library Area: Workload priority:p1 High priority but not blocking.
Projects
None yet
Development

No branches or pull requests

2 participants