SignIns Unknown AppliedConditionalAccessPolicyResult

[L4r1k]

Hitting the SignIns list MS Graph API endpoint results in either of the following issues:

• Unknown AppliedConditionalAccessPolicyResult value: reportOnlyFailure
• Unknown AppliedConditionalAccessPolicyResult value: reportOnlyNotApplied

I believe this may be related to how the metadata is presenting the AppliedConditionalAccessPolicyResult, i.e. it differs from what is actually returned by the API and therefore go doesn't parse it correctly. Possibly similar to what's occurring the beta msgraph-sdk-go microsoftgraph/msgraph-beta-sdk-go#224 ?

[baywet]

Hi @L4r1k
Thanks for reporting this.
It seems the service is replying with enum member values that are not documented in the metadata, hence absent from this SDK.
Could you please provide the code path, or API path you're using to make the request?
@rkodev once we have that information, please open an ICM on the service team.

[L4r1k]

Sure, the main endpoint I'm hitting is client.AuditLogs().SignIns() and here's the general gist of my code (consolidated for clarity) for a bit more context:

import (
        ...
	graph "github.com/microsoftgraph/msgraph-sdk-go"
	daudit "github.com/microsoftgraph/msgraph-sdk-go/auditlogs"
)
...

headers := abstractions.NewRequestHeaders()

var filter string = fmt.Sprintf("createdDateTime ge %s and createdDateTime lt %s", startTime, endTime)
var pageSize int32 = 1000

requestParameters := &daudit.SignInsRequestBuilderGetQueryParameters{
  Filter: &filter,
  Top:    &pageSize,
}

configuration := &daudit.SignInsRequestBuilderGetRequestConfiguration{
  Headers:         headers,
  QueryParameters: requestParameters,
}

var req *daudit.SignInsRequestBuilder
req = client.AuditLogs().SignIns()
result, err := req.Get(context.Background(), configuration) // <- error occurs here

where startTime/endTime are time strings in the format of time.RFC3339. The error occurs on the first request prior to reaching the subsequent page iterator (not shown above).

As noted here, if I switch to using the beta version of msgraph-sdk, I get a different error at the same line for what I'm assuming is a similar metadata related issue. If i print out the exact request being made and hit it from curl/ms graph explorer/etc. it returns data just fine. I have looked through the package inspecting how Go parses the metadata/signin model and, as you noted, the two don't seem to line up hence my assumption that metadata is the issue. I also can't easily extract the returned data anyway as this package drops the returned data if any error occurs (result is nil) 😢

[baywet]

Thanks for the additional information. this is the endpoint we're referring to here. @rkodev when you have a couple of minutes, can you open an ICM on that team so they add the missing enum values or stop returning them in v1 please?

[L4r1k]

Hi, has there been any movement on this? It's a big blocker for my application 😢

[baywet]

Thanks for the nudge here. And for your patience. I created the ICM myself and I'll let you know about the reply from the service team.
https://portal.microsofticm.com/imp/v3/incidents/incident/446051639

[baywet]

Update from the ICM: the service team has made the metadata changes to include the missing enums values, they have been merged. The change is under deployment. However, those changes are only deployed weekly and we have a number of deployment freezes due to the end of the year celebrations. If that change doesn't make it in the next 2 weeks, it's likely it'll only get deployed in January.

[L4r1k]

Cheers Vincent! Thanks for your help. 🤞 it gets deployed inside 2 weeks in that case

[baywet]

update from the service team: deployment complete. Which means our generation pipeline should pick it up next tuesday.