fix: require regular version in stubs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we stub files for environments that do not handle export maps very well, we `require` a transpiled CJS implementation and re-export it in a stub file that should be immediately overriden by the `browser` or `exports` fields in `package.json`. At the moment we use the value from the `browser` overrides to work out which file we should `require` the stub. The change here is to `require` the transpiled regular CJS version in the stub instead of the browser override. Turns out when Jest has `testEnvironment: 'node'` set it resolves `require`s to the stubs, ignoreing `exports` which loads browser-specific code into node with predictably incendiary results.
|
Fixes: ipfs/js-ipfs#3938 |
rvagg
approved these changes
Nov 24, 2021
src/package/index.js
Outdated
|
|
||
| return stubs | ||
| } | ||
|
|
||
| async stubFiles (dist, overrides) { | ||
| if (typeof overrides === 'string') { |
There was a problem hiding this comment.
these 3 lines can be removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we stub files for environments that do not handle export maps very well, we
requirea transpiled CJS implementation and re-export it in a stub file that should be immediately overriden by thebrowserorexportsfields inpackage.json.At the moment we use the value from the
browseroverrides to work out which file we shouldrequirethe stub. The change here is torequirethe transpiled regular CJS version in the stub instead of the browser override.Turns out when Jest has
testEnvironment: 'node'set it resolvesrequires to the stubs, ignoringexportswhich loads browser-specific code into node with predictably incendiary results.