Replace pytest-flake8 with a pre-commit hook #82
Labels
enhancement
New feature or request
Comments
miketheman
added a commit
that referenced
this issue
Dec 21, 2021
There's weird behaviors with Flake8 interacting with pytest. Instead of using pytest to run the tests, make it a pre-commit hook. Resolves #82 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
added a commit
that referenced
this issue
Dec 21, 2021
There's weird behaviors with Flake8 interacting with pytest. Instead of using pytest to run the tests, make it a pre-commit hook. Resolves #82 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
DevL
added a commit
to funnel-io/python-on-rails
that referenced
this issue
Feb 11, 2022
pytest-flake8 seems abandoned at this point Related issues in other repositories: * tholo/pytest-flake8#83 * miketheman/pytest-socket#82
This was referenced Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At some point, pytest and flake8 stopped working well together. See tholo/pytest-flake8#81 and related links.
This may get worse with pytest 7
On this thread, see a comment around running flake8 as part of pytest is considered an anti pattern.
I think that the more tooling we try to bake into a given pytest run, the harder it is to split them apart, so instead, let's adopt the
pre-commitframework for executing any stylistic checks we want prior to a commit - flake8, black, isort, and anything else we want, like editorconfig...This check would need to also run on CI so that if an author doesn't run it locally, it'll catch anything missing.
The text was updated successfully, but these errors were encountered: