Bug in seed

[youkaichao]

Here is a bug. The seeds self._seed are integers, and str.join on list of integers will raise an exception. This makes the NIPS 2020 MineRL very hard to start :( I'm puzzled for days.

            if self.status_dir:
                cmd += ['-performanceDir', self.status_dir]
            if self._seed:
                cmd += ['-seed', ",".join(self._seed)]

            cmd_to_print = cmd[:] if not self._seed else cmd[:-2]
            self._logger.info("Starting Minecraft process: " + str(cmd_to_print))
            # print(cmd)

[MadcowD]

@youkaichao Can you provide a minimal example of where this fails!

Sorry again for all of the bugs!

[MadcowD]

Here is a PR that fixes it, but I'd like to actually reproduce the bug first because I haven't run into this bug before. #370

[youkaichao]

I'd like to actually reproduce the bug first because I haven't run into this bug before

I encountered this when using the minerl competition submission template here

[dzorlu]

I second this. Having the same issue. Running /utility/evaluation_locally.sh --verbose gives the following:

TypeError: sequence item 0: expected str instance, int found
 +--- This exception occured remotely (Pyro) - Remote traceback:
 | Traceback (most recent call last):
 |   File "/home/deniz/anaconda3/envs/minerl/lib/python3.8/site-packages/Pyro4/core.py", line 1424, in handleRequest
 |     data = method(*vargs, **kwargs)  # this is the actual method call to the Pyro object
 |   File "/home/deniz/anaconda3/envs/minerl/lib/python3.8/site-packages/minerl/env/malmo.py", line 476, in launch
 |     self.minecraft_process=  self._launch_minecraft(
 |   File "/home/deniz/anaconda3/envs/minerl/lib/python3.8/site-packages/minerl/env/malmo.py", line 668, in _launch_minecraft
 |     cmd += ['-seed', ",".join(self._seed)]
 | TypeError: sequence item 0: expected str instance, int found
 +--- End of remote traceback

Happy to provide more details. Thank you!