Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't match a real image #9

Open
vinowan opened this issue Nov 10, 2023 · 3 comments
Open

can't match a real image #9

vinowan opened this issue Nov 10, 2023 · 3 comments

Comments

@vinowan
Copy link

vinowan commented Nov 10, 2023

just run some test

target image is
bricks

and run the following command:

python .\test_optimizer.py .\sbs\match_v1\bricks.sbs -e -im bricks.jpg

python .\test_hybrid_optimizer.py .\sbs\match_v1\bricks.sbs -e -im bricks.jpg -m combine  -ip .\result\bricks\optim_bricks\checkpoints\optimized.pth -o bricks_hyper 

optimized image is
optimized

The simulated annealing algorithm seems to be unable to find the correct scale parameters.

@Polar1s
Copy link
Contributor

Polar1s commented Nov 13, 2023

Hi @vinowan. Could you add -a grid to the command that calls the hybrid optimizer? The mixed-integer optimization algorithm used in our paper is coordinate descent + grid search, not simulated annealing.

@mfischer-ucl
Copy link

Hi @Polar1s , thanks for the great work! A question regarding the above issue: I tried running the script with the -a grid command proposed by you. It is taking forever (6 hrs in, and still running) - is it intended that there are 10k gridsearch iterations, and during each gridsearch iteration there are 100 linesearch iterations per parameter? For the brick example above, this would create 47 parameters * 100 linesearch iters * 10k gridsearch iters, leading to 47 million iterations? I suspect these many renderings are what increase the runtime so much. Thanks :)

@Polar1s
Copy link
Contributor

Polar1s commented Feb 19, 2024

Hi @mfischer-ucl

Sorry for getting back late and thank you for providing the details of your experiment. The optimization time indeed scales with the number of renderings. 10k grid search iterations and 100 line search iterations are apparently way too much.

For your reference, we only ran 5 grid search iterations with 100 line search iterations (if I recall correctly) for the results in the paper. We observed that the coordinate descent optimizer typically converged after ~5 grid search iterations.

Meanwhile, a large number of parameters (especially continuous ones) also adds to the overall time cost. I would suggest exposing the subset of parameters you're mostly interested in and limiting the optimization to those exposed parameters. Please let me know if you run into further issues. Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants