Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTestHarnessPath path resolution difficult to use with inherited settings #808

Open
wnayes opened this issue Oct 31, 2021 · 1 comment
Labels

Comments

@wnayes
Copy link
Contributor

wnayes commented Oct 31, 2021

If the CustomTestHarnessPath setting is defined in an ancestor/parent settings file, and there are multiple settings files in the inheritance hierarchy, the harness path will be resolved relative to the settings file closest to the test spec files rather than the settings file that defined it.

This makes it difficult to use the CustomTestHarnessPath setting in a shared way across a repository. I'd expect a relative path to resolve relative to the config file that defined it, or some way to configure this type of behavior (similar to SettingsFileAdjacent for other settings).

Example

// C:\repo\chutzpah.json
{
    "CustomTestHarnessPath": "TestHarness\\Harness.html"
}

// C:\repo\a\b\c\chutzpah.json
{
    "InheritFromParent": true,
}

When running a test that uses the C:\repo\a\b\c\chutzpah.json, the harness path seems to resolve against C:\repo\a\b\c\ instead of C:\repo\ where the parent settings file is. For any relative path, this typically means it will break.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant