Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: flat map with "both" on top of one another #9306

Closed
kingjr opened this issue Apr 16, 2021 · 7 comments · Fixed by #9315
Closed

BUG: flat map with "both" on top of one another #9306

kingjr opened this issue Apr 16, 2021 · 7 comments · Fixed by #9315
Labels
Milestone

Comments

@kingjr
Copy link
Member

kingjr commented Apr 16, 2021

Using stc.plot(surface='flat', hemi='both') leads to a superposition of the two hemispheres:

Screen Shot 2021-04-16 at 4 57 44 PM

(in addition, the conventional orientation of flat map is rotated 90* compared to what mne plots:
image
)

@kingjr kingjr added the BUG label Apr 16, 2021
@larsoner
Copy link
Member

  1. We should just not allow hemi='both' when using a flatmap and tell people to use hemi='split' (ValueError)
  2. We should fix the orientation, it's a regression since https://mne.tools/dev/auto_tutorials/source-modeling/plot_visualize_stc.html is wrong but https://mne.tools/stable/auto_tutorials/source-modeling/plot_visualize_stc.html is correct (can you confirm @kingjr ?)

@larsoner larsoner added this to the 0.23 milestone Apr 16, 2021
@larsoner
Copy link
Member

@kingjr if you want to take a stab at the ori fix at least, it should be that this line needs an appropriate roll= in degrees:

https://github.com/mne-tools/mne-python/blob/main/mne/viz/_brain/view.py#L41

@larsoner
Copy link
Member

... although I guess we could allow hemi='both' and add an appropriate offset so they show up in the correct locations relative to one another. This might actually be preferable to hemi='split' in some situations. So I think I changed my mind on (1) above.

@kingjr
Copy link
Member Author

kingjr commented Apr 16, 2021

  1. I vote for an offset, it's easier to handle zoom in some cases.
  2. hard to tell for an auditory response! I would only confirm for a visual one (alternatively, a quick check can be done by using the highlight by area option made by @GuillaumeFavelier)

it's hard for me to do PR on anything related to pyvista, because I only have it working on a headless, and I'm experiencing some painful lag

@GuillaumeFavelier
Copy link
Contributor

No worries, I can add that to my todo list and update #7162

@larsoner
Copy link
Member

@GuillaumeFavelier can you take a look?

@GuillaumeFavelier
Copy link
Contributor

I'm on it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants