Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up impsort and formatter plug-in #2

Closed
gunnarmorling opened this issue Aug 3, 2021 · 5 comments
Closed

Set up impsort and formatter plug-in #2

gunnarmorling opened this issue Aug 3, 2021 · 5 comments
Assignees
@aalmiray

Comments

@gunnarmorling
Copy link
Member

I could swear this was in place already for JfrUnit, but perhaps not? If not, config can be copied from kcctl.

// CC @aalmiray
@gunnarmorling
Copy link
Member Author

Applied locally to JfrUnit for now via moditect/jfrunit#76.

@aalmiray
Copy link
Collaborator

aalmiray commented Aug 3, 2021

Yeah, those plugins are missing in the parent pom. I'll add them.

@aalmiray aalmiray self-assigned this Aug 3, 2021
@gunnarmorling
Copy link
Member Author

Thx! Wanna cut a 1.0.1.Final release of the parent POM with this change?

@aalmiray
Copy link
Collaborator

aalmiray commented Aug 3, 2021

I was hoping there could wait for #1 which depends on an external fix.
That being said the current enforcer version in use (3.0.0-M3) is working alright.

@gunnarmorling
Copy link
Member Author

That makes sense, there's no hurry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalmiray aalmiray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aalmiray @gunnarmorling