Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] add Deno runtime in benchmark #1267

Open
scarf005 opened this issue Jun 11, 2024 · 13 comments
Open

[Enhancement] add Deno runtime in benchmark #1267

scarf005 opened this issue Jun 11, 2024 · 13 comments

Comments

@scarf005
Copy link

scarf005 commented Jun 11, 2024

adding Deno runtime to benchmark would be useful, especially since Deno runs typescript as first class citizen.

i'm interested in opening a PR if it's acceptable. (I'd be grateful for pointers on where to work)

@kravetsone
Copy link

#1225

Now Bun runtime added so Deno will be accepted i guess

Not fan of Deno but for better runtimes comparison it would be useful!

@scarf005
Copy link
Author

Not fan of Deno

could you elaborate?

@DarkGL
Copy link
Contributor

DarkGL commented Sep 14, 2024

I have started to work on deno support here DarkGL#4

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

@scarf005
Copy link
Author

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

@DarkGL tinkering with it right now. you can see it in https://github.com/scarf005/typescript-runtime-type-benchmarks (it's a mess)
Some thoughts:

  • in order to add deno, code structure may need to have wildly changed.
  • in particular, start.sh, index.ts and benchmarks/main.ts may need to be changed a lot due to Deno lacking process and lacking node specific features.
  • could you share issues you encountered?
  • is CJS mandatory in running benchmarks? i could make Deno with ESM, not sure if it's possible with CJS
  • some imports had to be replaced with esm.sh imports due to some of the modules having malformed ESM support

@DarkGL
Copy link
Contributor

DarkGL commented Sep 14, 2024

I had a problem running deno test inside pr.yml, but I can already see after looking at your branch that there will be many more problems to resolve

@scarf005
Copy link
Author

scarf005 commented Sep 14, 2024

I'll try to work on it tomorrow, planning to generate package.json to esm.sh mapping so imports are properly resolved to ESM.

@kravetsone
Copy link

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

@DarkGL tinkering with it right now. you can see it in https://github.com/scarf005/typescript-runtime-type-benchmarks (it's a mess)
Some thoughts:

  • in order to add deno, code structure may need to have wildly changed.
  • in particular, start.sh, index.ts and benchmarks/main.ts may need to be changed a lot due to Deno lacking process and lacking node specific features.
  • could you share issues you encountered?
  • is CJS mandatory in running benchmarks? i could make Deno with ESM, not sure if it's possible with CJS
  • some imports had to be replaced with esm.sh imports due to some of the modules having malformed ESM support

Deno moment

@DarkGL
Copy link
Contributor

DarkGL commented Sep 14, 2024

Btw. I think CJS was used because packages lacked support for ESM, would be nice to know which one needs CJS currently and check if they shipped new version with ESM support

@scarf005
Copy link
Author

Deno moment

more of Node still not following browser standard moment :)

@kravetsone
Copy link

Not fan of Deno

could you elaborate?

nobody is interested in a Deno that will slowly die

also, with the 2.0 version, they will deceive many of their fans (they will remove the features of Deno)

Bun is more fine to me

It solve many problems and more faster than Deno

after many years in Deno, undici does not work on Windows...

I like that Bun is committed to drop-in replacement

It will be seen now) that a lot of changes will need to be made to support Deno

@DarkGL
Copy link
Contributor

DarkGL commented Sep 15, 2024

This shouldn't be a thread where we talk about deno vs bun or deno vs node.

Let's focus on integrating it.

@DarkGL
Copy link
Contributor

DarkGL commented Sep 22, 2024

@scarf005 with upcoming version 2 of deno do you think it will be easier to integrate?

@kravetsone
Copy link

@scarf005 with upcoming version 2 of deno do you think it will be easier to integrate?

It should be much easier because Deno abandoned his ideas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants