Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionalize ddMicrobunches #19

Open
balerion opened this issue May 3, 2018 · 2 comments
Open

Optionalize ddMicrobunches #19

balerion opened this issue May 3, 2018 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@balerion
Copy link
Collaborator

balerion commented May 3, 2018

I have been thinking of making the whole ddMicrobunches dataframe optional. Is this even necessary at all? we should have all the data in the dd dataframe anyway. If needed for debugging purposes, we can generate it optionally. Or, we could always generate it but have it empty if not required?

Just a proposition, no need to fuss about this if not necessary.

@balerion balerion added the question Further information is requested label May 3, 2018
@steinnymir
Copy link
Member

I totally agree with this. The generation of ddMicrobunch is time and space consuming, while almost never used at all.

@balerion
Copy link
Collaborator Author

balerion commented May 8, 2018

The ddMicrobunches is only used for diagnostics and for generating the histograms. We are looking into generating the histograms in other ways, using the dd dataframe, so this will be optionalized.

@balerion balerion added the enhancement New feature or request label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants