Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit comparator breaks under PHPUnit 10/comparator 5 #745

Closed
Firehed opened this issue Mar 30, 2023 · 1 comment
Closed

PHPUnit comparator breaks under PHPUnit 10/comparator 5 #745

Firehed opened this issue Mar 30, 2023 · 1 comment

Comments

@Firehed
Copy link
Contributor

Firehed commented Mar 30, 2023

There was a breaking change going from sebastian/comparitor:4 to 5, which by default you'll pull in updating to PHPUnit 10.

At a glance, there are two adjustments:

  • don't call parent::construct
  • add : bool return type to accepts

I think the latter is fine for forward compatibility, but the former may require some hacking to get around the loss of constructor

I'll take a quick attempt at a PR to address this.
@Firehed Firehed mentioned this issue Mar 30, 2023
Closed
@frederikbosch frederikbosch mentioned this issue Feb 6, 2024
Merged
@frederikbosch
Copy link
Member

Fixed by #784.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PHPUnit comparator under PHPUnit 10 Firehed/money
2 participants
@Firehed @frederikbosch