New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Psalm with PHPStan #798

Open

ruudk opened this issue Sep 12, 2024 · 3 comments

Contributor

ruudk commented Sep 12, 2024

Currently, Psalm blocks testing this on PHP 8.4 #796 .

I also wonder why the package uses Psalm, as PHPStan feels much more alive than Psalm.

Member

frederikbosch commented Sep 12, 2024

Why would Psalm be blocking that? I don't see any failed tests because of it.

Contributor Author

ruudk commented Sep 12, 2024

Because I added --platform-ignore-reqs=php to the PR in the meantime.

Member

frederikbosch commented Sep 12, 2024

Oh, I did not do a good review then, that's a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment