Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect fix for multi-line array #178

Open
andrewnicols opened this issue Jul 19, 2024 · 1 comment
Open

Incorrect fix for multi-line array #178

andrewnicols opened this issue Jul 19, 2024 · 1 comment

Comments

@andrewnicols
Copy link
Contributor

        $fields['maildigest'] = ['type' => PARAM_INT, 'null' => NULL_NOT_ALLOWED,
                'default' => $CFG->defaultpreference_maildigest, ];

Should be:

        $fields['maildigest'] = [
            'type' => PARAM_INT,
            'null' => NULL_NOT_ALLOWED,
            'default' => $CFG->defaultpreference_maildigest,
        ];
@stronk7
Copy link
Member

stronk7 commented Jul 22, 2024

Is that the NormalizedArrays.Arrays.CommaAfterLastsniff?

If so, yeah, that one is imperfect, recently we were able to get accepted some new error codes, in order to allow missing trailing commas when the closer (]) is in the same line (we allow that), but I imagine that, maybe, the fixer does not consider that. Tricky one as far as it's not ours...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants