Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this be converted to sniffs for PHP_CodeSniffer? #28

Open
polothy opened this issue Dec 18, 2015 · 5 comments
Open

Can this be converted to sniffs for PHP_CodeSniffer? #28

polothy opened this issue Dec 18, 2015 · 5 comments

Comments

@polothy
Copy link

polothy commented Dec 18, 2015

With PHP_CodeSniffer 2.0, I believe they have greatly improved their tokenizing of PHPDoc blocks. Would it now be possible to fold this into local_codechecker's PHP_CodeSniffer code standard?

@danpoltawski
Copy link
Contributor

+100 if we can do this - helps with IDE integration etc etc (finding someone who can do the work might be more difficult)

@polothy
Copy link
Author

polothy commented Dec 18, 2015

Just leaving this here, it must be completed before something like this could be attempted: https://tracker.moodle.org/browse/CONTRIB-5732

@stronk7
Copy link
Member

stronk7 commented Jun 8, 2016

For reference, link to (2y old) issue where a research about this was performed.

https://tracker.moodle.org/browse/CONTRIB-4165
(not saying we cannot re-evaluate the situation, just adding the reference)

@danpoltawski
Copy link
Contributor

Just been thinking about this and wondering.. if we could disable all the 'dumb' rules in this plugin which can be replaced by sniffs. Then just leave the more intelligent checks here if they can't be replaced. It's not perfect, but I think it's advantageous to do the move because of tooling support.

@andrewnicols
Copy link
Contributor

Work on this has started: https://github.com/moodlehq/moodle-cs/milestone/1

@andrewnicols andrewnicols added this to the Migrate to moodle-cs cod milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants