Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow async module deletes #14

Closed
ericmerrill opened this issue Dec 3, 2020 · 1 comment · Fixed by #17
Closed

Allow async module deletes #14

ericmerrill opened this issue Dec 3, 2020 · 1 comment · Fixed by #17
Labels
enhancement New feature or request

Comments

@ericmerrill
Copy link
Contributor

In tool_migratehvp2h5p\finish_migration, course_delete_module() is called, but the async parameter isn't passed, meaning the tool call itself has to wait for the delete, which itself isn't too bad, but if you have the recycle bin on (which is default), it also has to wait for a backup to be completed first. This takes forever on large sites.

Personally, I think we should be calling course_delete_module() with async true, or at least expose an option to do that. The original course module will instantly be removed as deleted to users, and adhoc tasks from recycle bin then do that background work of backing up/actually deleting them.

@sarjona sarjona added the enhancement New feature or request label Dec 4, 2020
@sarjona sarjona linked a pull request Dec 7, 2020 that will close this issue
@sarjona
Copy link
Member

sarjona commented Dec 7, 2020

Thanks a lot for the suggestion, Eric!
I agree with you that $async parameter will help to improve performance and, as I can't see any benefit of adding it as a setting for the plugin, I've changed it to true in the code.

If anybody has any reason for having it as a setting, I'll be happy to create it but, for now, I think is better to set it to true in order to keep the plugin as simple as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants