Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide if we want to fallback on "in-patch" instead of latest revision by date #1716

Open
marco-c opened this issue May 11, 2023 · 0 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented May 11, 2023

With latest revision by date, in case the parent revision of a patch is not public or was not analyzed and stored in the backend for some reason, we can overpublish.

E.g. this happened in https://phabricator-dev.allizom.org/D3533, where the revision couldn't be found on the backend (since the revision is from staging m-c).
In ab25e7dfc0dc5bb8217fb436aac0957faf03a793, the issue was there.
In ffee8e3a7870875ab78af162638548f72cdabddf, the issue was not there anymore because it was fixed.
Andi's revision is based on ab25e7dfc0dc5bb8217fb436aac0957faf03a793, so the issue is still there in his revision.
When we get the latest revision by date, we get ffee8e3a7870875ab78af162638548f72cdabddf (or newer), and so the issue is not there
and so we consider the issue as new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant