Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't warn about "0 errors" before landing #1956

Open
Tracked by #2273
Archaeopteryx opened this issue Nov 6, 2023 · 0 comments
Open
Tracked by #2273

don't warn about "0 errors" before landing #1956

Archaeopteryx opened this issue Nov 6, 2023 · 0 comments
Labels
teklia-2024 Issue for Teklia work in 2024

Comments

@Archaeopteryx
Copy link
Contributor

When https://phabricator.services.mozilla.com/D191007 was landed, it showed the following message before landing which needed be confirmed:

The code review bot found 0 errors which should be fixed to avoid backout and 4 warnings.

If there are 0 errors, the message should be less scary and only mention the warnings (which won't cause a backout).

The code lives here.

@Archaeopteryx Archaeopteryx changed the title The code review bot found 0 errors which should be fixed to avoid backout and 4 warnings. don't warn about "0 errors" before landing Nov 6, 2023
@Archaeopteryx Archaeopteryx added the teklia-2024 Issue for Teklia work in 2024 label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teklia-2024 Issue for Teklia work in 2024
Projects
None yet
Development

No branches or pull requests

1 participant