-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory-discarded tabs move to the default container when relaunching/resuming Firefox #1719
Comments
The workaround: Either Hide the container again, or click on any discarded tabs to "wake" them up, before exiting Firefox. |
Perhaps this has something to do with FireFox itself? I'm constantly closing FireFox and re-opening it to test things. I have always used "Restore Session" by default, so this was no surprise to me. I don't know when it started but, all tabs would fail to load fully. Only the last active tab opens. However, not in normal state. I noticed all my tabs are in cache state, even the last active tab. There's even a yellow ! bubble mark that says "Loaded from Cache" "Mozilla" on the right in the address bar. Additionally, I'm unable to "scroll" up or down to view the tabs (I use Tree Style Tabs with Middle Click to navigate to the next/previous tab). |
This comment has been minimized.
This comment has been minimized.
Yes, I still have this problem on Firefox 89.0b3 (Developer Edition). The steps to reproduce in my original post still reproduce the bug. |
Thank you. Can you make the bug reproducible with multiple windows? For containment to fail when a tab that was discarded in a second (or subsequent window) is adjacent to the first restored tab when the window is restored. ThoughtsThe potential for leakage and loss of privacy may be significant; we can not expect end users to notice whenever containment silently fails. Given Mozilla's emphasis on privacy, IMHO the underlying bug should be P1. HereWithout aiming to, a few hours ago I stumbled into what might be the same (Firefox) bug with a single window and Multi-Account Containers alone enabled. Three frames from a screen recording:
– the page simply loaded, without the extension asking about containment. The preference to always open the site in the container was set (page action) and confirmed (toolbar button) during the session, not long before the affected tab loaded without containment. It was a single-window session, with my clean profile (the other Firefox windows were from a separate run of the application with my default profile). This example was slightly unusual in that:
Whilst all CPUs were 100% busy, the computer did not feel unduly slow. Around 6 of 16 G encrypted swap was in use, however the related hard disk drive at |
Off-topic from Firefox containers and the Multi-Account Containers extension,
For many pages, this is normal. ▶ https://chat.mozilla.org/ or https://discourse.mozilla.org/ if you like to learn more. I'm grahamperrin in both areas; any number of other people should be able to help.
|
Another workaround:
|
@Rob--W above #1719 (comment), the three frames from a screen recording. Please: does this smell like anything that is, or should be, in the dependency tree for
|
I don't know for sure. I read this report and comments and your screenshots, but it's not clear whether there is an issue with session restore logic in Firefox. The container state of a tab is certainly part of the properties that's restored by Firefox as part of session restore. In https://hg.mozilla.org/mozilla-central/rev/bf8b505e273d (part of https://bugzilla.mozilla.org/show_bug.cgi?id=1695346 ), I recently (Firefox 89) fixed a bug related to detection of tab URL of discarded tabs when the tab hiding extension API is used. This MAC extension doesn't use tab hiding though. I ran the STR here and compared Firefox's session restore files. There is no difference between the session with the restored tab and the session without. So it could be that the internal "userContextId" tab ("cookieStoreId") restored by the extension isn't persisted to session restore as expected. |
Actual behavior
Context: When you launch Firefox and resume a previous session, tabs start out in what I think is called a "discarded" state. Right? The webpages do not all load into memory until you click on each tab. The same thing happens when you Hide and Show a container. Tabs remain discarded until you click on them.
The problem: If you exit Firefox while any of your container tabs are discarded, then when you launch Firefox again, all of that container's tabs will have switched back to the default container. You will have to reopen each tab in its previous container again.
Expected behavior
Container tabs should always stay in their containers across Firefox sessions.
Steps to reproduce
firefox -P test
)test
profile again. Notice all three container tabs are now in the default container.The text was updated successfully, but these errors were encountered: