Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Select text with the pointer hovering an existing highlight must check that an existing highlight is ignored on hovering" integration test #18775

Open
timvandermeij opened this issue Sep 22, 2024 · 0 comments
Labels

Comments

@timvandermeij
Copy link
Contributor

This integration test fails consistently on only the Windows bot with the following traceback (see http://54.193.163.58:8877/662f7dec318944a/output.txt):

Failures:
1) Highlight Editor Select text with the pointer hovering an existing highlight must check that an existing highlight is ignored on hovering
  Message:
�[31m    In chrome: Expected 1 to equal 0.�[0m
  Stack:
        at <Jasmine>
        at file:///C:/pdfjs/botio-files-pdfjs/private/662f7dec318944a/test/integration/highlight_editor_spec.mjs:1880:58
        at async Promise.all (index 1)
        at async UserContext.<anonymous> (file:///C:/pdfjs/botio-files-pdfjs/private/662f7dec318944a/test/integration/highlight_editor_spec.mjs:1834:7)

The earliest occurrence I could find of this test failure is #18698 (comment), so perhaps that patch introduced a regression (other than #18716). We could try to check if it still fails without that patch, and if so we might have a better idea about what changed.

PR #18721 attempts to debug/resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant