Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release should contain final built versions #47

Closed
soapdog opened this issue Jul 18, 2017 · 3 comments
Closed

Release should contain final built versions #47

soapdog opened this issue Jul 18, 2017 · 3 comments

Comments

@soapdog
Copy link

soapdog commented Jul 18, 2017

Hi,

The releases tab here in Github should contain the built versions of the polyfill including the final compressed version. The way it is now, it forces all users to download and build their own version which is basically equal to everyone else version.

Cheers

@shanemcgraw
Copy link

What's more, according to #41, a fresh build results in an eslint error 🙁

@rpl
Copy link
Member

rpl commented Sep 25, 2017

There is no need to rebuild locally, the dist files for the released versions of the npm package can be retrieved from unpkg, e.g.:

but I agree, we should add a direct link which points to the dist directory on unpkg for every release description to make it easier to reach them (and I edited the release descriptions to include this link).

@Rob--W
Copy link
Member

Rob--W commented Jul 19, 2018

The documentation now explains more clearly how to get the release files: https://github.com/mozilla/webextension-polyfill#installation

@Rob--W Rob--W closed this as completed Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants