Moved some bluetooth specific code from each implementation to a common place #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-manuel
reviewed
Jul 16, 2024
Adding else: to stop errors from occurring The old BLE bms implementations used ble_ as a prefix. Not using that might cause the battery to not be detected as the same battery if someone upgrades dbus-serialbattery. So best to just keep prefixing with "ble_"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same code was duplicated making things harder to read. This patch removes the duplicated code.
It also fixes en issue that could occur when a Bluetooth BMS was configured to be used but no address was given.